Commit Graph

1360 Commits

Author SHA1 Message Date
Reto Brunner 13a6a3fa71 FetchBodyPart doesn't need the parent body structure 2020-05-17 11:44:38 +02:00
Reto Brunner bae678e8f2 imap: Remove FetchMessageBodyPart.{Encoding,Charset}
Fixes https://todo.sr.ht/~sircmpwn/aerc2/352 exactly as suggested by emersion.
2020-05-16 20:03:42 +02:00
Reto Brunner ea2646fc03 Change MarkedMessages to return uids
Especially if one tries to interact with all marked messages there could be
the case that not all headers are fetched yet, hence the messageInfo is still nil.

This segfaults a lot of commands which in principle only need the uid to complete.

If we switch to uids, this issue can be alleviated for those commands.
2020-05-11 09:47:34 -04:00
Reto Brunner 381c1fc05f commands/helper: remove duplicated method 2020-05-11 09:47:33 -04:00
Reto Brunner c5fdefe7af msg/read: don't copy waitgroup 2020-05-11 09:47:25 -04:00
Reto Brunner fefb08f831 maildir: remove read handling from FetchMessageBodyPart 2020-05-11 09:47:21 -04:00
Reto Brunner ee1d971554 notmuch: remove read handling from FetchMessageBodyPart 2020-05-11 09:47:19 -04:00
elumbella d8533e897a Show 'Message sent' only for ten seconds instead of permanently 2020-05-11 09:46:57 -04:00
Reto Brunner 5790023568 creak/pty got force pushed: fix version 2020-05-08 22:32:28 +02:00
Guillaume J. Charmes dc281e46d2 Use stdout as controlling terminal
Soves an issue with go1.15 not letting ctty be a parent. See
https://github.com/creack/pty/pull/97 for more details.

Signed-off-by: Guillaume J. Charmes <git+guillaume@charmes.net>
2020-05-06 10:26:15 -04:00
Drew DeVault 38a6d187b9 Revert "Dont detach process under vterm"
This reverts commit d07cf6c667.
2020-05-06 10:03:20 -04:00
Guillaume J. Charmes d07cf6c667 Dont detach process under vterm
Signed-off-by: Guillaume J. Charmes <git+guillaume@charmes.net>
2020-05-06 10:01:10 -04:00
Reto Brunner 6bd6690d80 templates: add version func
Fixes #316
2020-05-06 10:00:59 -04:00
Reto Brunner 434eaa19a1 docs: extract template function to their own section
The functions were located in the data section, which was suboptimal.
2020-05-06 10:00:58 -04:00
Reto Brunner b03a73726d lib/messageview: mark messages as read
Currently at least the notmuch and maildir worker only set messages as read
if a body part is fetched. The gpg abstraction however fetches the full message.

We can simply set the readstate when we create the messageview, avoiding the issue.

Once this is merged, we can cleanup both workers.
2020-05-06 10:00:46 -04:00
Reto Brunner 8f2e5055ee msg/reply: Deduplicate TO: and CC:
If a recipient is already in TO:, there's no need to also put them in CC:
2020-05-06 10:00:36 -04:00
elumbella d1600e4666 Guess date from received if not present 2020-05-06 10:00:33 -04:00
Grégoire Delattre 9a520c4098 Allow maildir subdirectories 2020-05-05 19:18:26 +02:00
Drew DeVault 52eb38ae5d libui: don't require beeper for main content 2020-05-05 09:57:29 -04:00
burrowing-owl 866cd17dd7 Fix array out of bounds error 2020-05-05 09:01:08 +02:00
Ben Fiedler 05fa79eb8e store.FetchFull: Change callback type to expose entire message
This is a prerequisite for allowing the FetchFull message to return both
the message content and the message headers.
2020-05-01 11:10:08 -04:00
Ray Ganardi b650bb30a2 Implement :header command
Usage: *header* [-f] <field> [value]
	Add a new email header. If the header already exists, -f must be
	specified to replace the given value.
2020-05-01 11:01:28 -04:00
Ben Cohen 63fb2b2006 Changing aerc.conf delimiter parsing to use only =, and not : as well 2020-04-29 09:45:34 +02:00
Erazem Kokot d3faf66c50 Remove unecessary <Enter> from aerc.conf.in
The new-email config example has "<Enter>" at the end unecessarily,
since this makes the "<Enter>" text show up in a notification instead of
functioning as a Return keypress.
2020-04-28 00:25:49 +02:00
Reto Brunner 94ce215e58 add template structure to aerc-templates(7) 2020-04-26 12:44:48 +02:00
Reto Brunner 2632a1a8ad aerc-config: remove bold modifier within text
Partial bold ("highlighted") text looks very strange and it doesn't
really add anything, might as well remove it.
2020-04-26 12:39:49 +02:00
Reto Brunner 432d2b1592 remove mention of header addition via the editor from tutorial 2020-04-24 23:51:47 +02:00
Drew DeVault edec4390c5 Fix headers in built-in templates 2020-04-24 12:59:49 -04:00
Drew DeVault 6f8ad91824 gofmt fixes 2020-04-24 12:59:40 -04:00
Ben Fiedler 92f59ef94a imap/fetch.go: report error when fetching headers fails
Correct me if I'm wrong, but shouldn't this raise an error when it
fails?
2020-04-24 12:59:21 -04:00
Jeffas 3102ac3680 Add recall command
This command allows recalling the selected postponed email to edit in
the composer. The command only allows recalling from the postpone
directory.
2020-04-24 12:59:21 -04:00
Jeffas 7f033278eb Add postpone command
This command uses the Postpone folder from the account config to save
messages to. Messages are saved as though they were sent so have a valid
'to' recipient address and should be able to be read back in for later
editing.
2020-04-24 12:59:21 -04:00
Ray Ganardi 447e662057 Add :choose command
Usage:
	*choose* -o <key> <text> <command> [-o <key> <text> <command>]...

Prompts the user to choose from various options.
2020-04-24 12:59:21 -04:00
Reto Brunner acf69b7490 Remove ability to specify headers in the editor
Due to headers being essentially free text, we constantly run into issues
with parts of the body being interpreted as headers.

Remove the ability to overwrite headers to avoid that, while keeping the ability
to specify headers in the template files.

Fixes #383
2020-04-24 12:59:21 -04:00
Reto Brunner 3fa9ae3edb templates/quoted_reply: fix incorrect timezone identifier 2020-04-24 07:19:59 +02:00
Ben Fiedler 955b5c22b5 Ensure documented defaults match given defaults 2020-04-23 21:06:29 +02:00
Ben Fiedler 7c89143c70 Use aerc.PushError where appropriate
Forgot an unused import, to save you the hassle here is v2.
2020-04-23 21:02:45 +02:00
Anirudh Oppiliappan 280d8e7e1c Bump ProtonMail/crypto to fix build on OpenBSD
Signed-off-by: Anirudh Oppiliappan <x@icyphox.sh>
2020-04-20 18:55:04 +02:00
Ray Ganardi 06bb332285 fix binding for delete message
I guess confirm command was removed sometime ago, but the config
template was not updated.
2020-04-20 10:52:09 -04:00
Ray Ganardi 5b751b6d6d fix: Close unused MessageView when swapping view
Closes https://todo.sr.ht/~sircmpwn/aerc2/379

The old `MessageView` was not closed when replacing the tab content, which
causes a memory leak.
2020-04-20 10:48:40 -04:00
Nicolai Dagestad f35002ad0e Make the http handler of the unsubscribe command async 2020-04-16 19:16:11 +02:00
Reto Brunner 8c023cdb38 Readme: add config location of MacOS 2020-04-12 15:53:44 +02:00
Reto Brunner 1fbce012ed msg/archive: complete the possible options 2020-04-11 10:46:46 -04:00
Reto Brunner 2b53347d0d README: include demo and update required go version 2020-04-07 14:50:13 -04:00
Reto Brunner c4deaf22a0 go mod tidy, updated go.sum 2020-04-06 13:37:46 +02:00
Galen Abell 95fb35b701 Try to open attachments with correct extension
The temporary file created when opening an attachment is currently saved
without an extension, which prevents matching on file ending with
xdg-open.
2020-04-06 13:15:56 +02:00
Jonathan Halmen 35402e21d9 fix function keys in terminal widget
off-by-one error
2020-03-26 16:04:11 -04:00
Simon Ser 294fead7ab Requires Go 1.13
We use errors.Is, which has been introduced in Go 1.13.
2020-03-20 10:44:50 -04:00
Drew DeVault 696f4ff084 msgviewer: do not interpret header as format string 2020-03-19 18:33:42 -04:00
Zoltan Kalmar 8372e9e39f Add quotes to the default pinned-tab-marker
It's a fix for: https://todo.sr.ht/~sircmpwn/aerc2/361
Using an unquoted backtick char is leading to a config error:

```
Failed to load config: missing closing key quote from '`
' to ''
```
2020-03-13 09:09:56 -04:00