Reto Brunner 1687e558d3 notmuch/maildir: remove double emit of the dirinfo ... There was some bug which could be worked around by double emitting an event. However that proofed to be brittle: We send the first message here from the worker goroutine: https://git.sr.ht/~sircmpwn/aerc/tree/a5553438/item/worker/maildir/worker.g= o#L306 Then Tick() is waked in the main goroutine and calls ProcessMessage: https://git.sr.ht/~sircmpwn/aerc/tree/a5553438/item/widgets/account.go#L100 ProcessMessage in the main goroutine reads types.Message state with msg.getId() and msg.InResponseTo(): https://git.sr.ht/~sircmpwn/aerc/tree/a5553438/item/worker/types/worker.go#= L74-76 Meanwhile in the worker goroutine we call PostMessage for a second time with a pointer that points to the *same* previous message that ProcessMessage is reading: https://git.sr.ht/~sircmpwn/aerc/tree/a5553438/item/worker/maildir/worker.g= o#L306 The second PostMessage call makes writes to message while ProcessMessage in the main goroutine is possibly reading: https://git.sr.ht/~sircmpwn/aerc/tree/a5553438/item/worker/types/worker.go#= L59 This led to a data race in the event loop Reported-By: Wagner Riffel <w@104d.net>		2021-04-28 07:54:16 +02:00
..
container.go	maildir: Provide nicer error message on invalid url	2020-07-27 18:26:57 +02:00
message.go	maildir: don't read the full file into memory	2021-02-08 09:06:42 +01:00
search.go	Remove hard coded bodystruct path everywhere	2020-07-27 09:19:27 +02:00
worker.go	notmuch/maildir: remove double emit of the dirinfo	2021-04-28 07:54:16 +02:00