1
0
Fork 0
qmk_firmware/drivers/issi
yiancar c0fe8dbfb4 IS31FL3733 Dirty page fix (#7079)
* IS31FL3733 Dirty page fix

Function IS31FL3733_update_led_control_registers was never setting update register to false. As a result the led on/off page was being written every transaction even when it was not modified. This is ineficient and causes lots of bandwidth use.

-> Fix the IS31FL3733_update_led_control_registers.
-> After testing it was evident that failed I2C transactions could corrupt the Led on/off register.
-> Update IS31FL3733_write_pwm_buffer and IS31FL3733_write_register functions to return 0 upon succesful tranmission and 1 if any of the transmitions within the function fail.
-> Modify IS31FL3733_update_pwm_buffers function so if any of the IS31FL3733_write_pwm_buffer transuction fails, the g_led_control_registers_update_required register is set to true forcing a rewrite of the led on/off register in case it was corrupted.

* Minor comment update

* Upsie:)

* Update is31fl3733.c

* Return fix

* more return fix

* type change

* more boolian logic reversal:)
2019-11-25 20:33:52 +00:00
..
is31fl3218.c clang-format changes 2019-08-30 15:01:52 -07:00
is31fl3218.h clang-format changes 2019-08-30 15:01:52 -07:00
is31fl3731-simple.c clang-format changes 2019-08-30 15:01:52 -07:00
is31fl3731-simple.h clang-format changes 2019-08-30 15:01:52 -07:00
is31fl3731.c clang-format changes 2019-08-30 15:01:52 -07:00
is31fl3731.h clang-format changes 2019-08-30 15:01:52 -07:00
is31fl3733.c IS31FL3733 Dirty page fix (#7079) 2019-11-25 20:33:52 +00:00
is31fl3733.h IS31FL3733 Dirty page fix (#7079) 2019-11-25 20:33:52 +00:00
is31fl3736.c clang-format changes 2019-08-30 15:01:52 -07:00
is31fl3736.h clang-format changes 2019-08-30 15:01:52 -07:00
is31fl3737.c clang-format changes 2019-08-30 15:01:52 -07:00
is31fl3737.h clang-format changes 2019-08-30 15:01:52 -07:00