1
0
Fork 0
qmk_firmware/quantum
Gergely Nagy acda2b793f tap-dance: Do not start a sequence on keyup
There was an odd case, which confused the hell out of tap-dance: suppose
you had a number of tap-dance keys, on a layer, and as part of the
tap-dance, you turned that layer off - or had it on one-shot to begin
with. In this case, the keydown event would trigger the tap-dance key,
but the keyup would not. This had two funky consequences:

- tap-dance did not correctly register that the dance has ended.
- pressing any other tap-dance key would interrupt the previous
  tap-dance, and potentially input unwanted characters.

To fix this, we simply do not start a tap-dance sequence on keyup, only
when it is pressed. This way the previous sequence has enough time to
time-out and finish properly, and we don't get confused.

This fixes algernon/ergodox-layout#107.

Signed-off-by: Gergely Nagy <algernon@madhouse-project.org>
2016-09-01 08:32:47 +02:00
..
audio Add IN_LIKE_FLINT song 2016-07-30 01:52:33 -07:00
keymap_extras Removed unnecessary comment 2016-08-07 11:07:38 -05:00
process_keycode tap-dance: Do not start a sequence on keyup 2016-09-01 08:32:47 +02:00
serial_link Convert tirple_buffered_object_tests to GTest 2016-08-27 21:57:49 +03:00
template Fix the keyboard template with new make syntax 2016-08-27 23:31:15 +03:00
tools Backlight abstraction and other changes (#439) 2016-06-23 22:18:20 -04:00
visualizer Move the visualizer_user file to keymap folder 2016-07-07 14:42:16 +03:00
analog.c quantum separated 2015-10-26 14:49:46 -04:00
analog.h quantum separated 2015-10-26 14:49:46 -04:00
config_common.h Added pin support for A0-A7 2016-08-25 00:15:41 -05:00
dynamic_macro.h Implement the dynamic macros that are recorded in runtime 2016-08-18 01:37:13 +02:00
keycode_config.c Cleans up quantum/keymap situation, removes extra lufa folders (#416) 2016-06-18 14:30:24 -04:00
keycode_config.h Add ChibiOS support for QMK (#465) 2016-07-01 10:04:53 -04:00
keymap.h fix typo 2016-08-12 20:38:26 +09:00
keymap_common.c Fixes midi functionality 2016-07-24 22:07:43 -04:00
light_ws2812.c updates rgblight implementation, makes non-timer stuff compatible with audio 2016-07-07 11:33:34 -04:00
light_ws2812.h Integrate WS2812 code into quantum core 2016-01-24 17:05:47 -08:00
matrix.c fix/annotate wait_us lines 2016-07-06 00:24:31 -04:00
quantum.c Add a register/unregister_code16 pair of functions 2016-08-18 11:29:53 +02:00
quantum.h Add a register/unregister_code16 pair of functions 2016-08-18 11:29:53 +02:00
rgblight.c Simplify HSV->RGB calculation 2016-07-26 15:31:22 -05:00
rgblight.h updates rgblight implementation, makes non-timer stuff compatible with audio 2016-07-07 11:33:34 -04:00